melos icon indicating copy to clipboard operation
melos copied to clipboard

request: depends-on filter should be applied to include-dependencies

Open ookami-kb opened this issue 2 years ago • 1 comments

Is there an existing feature request for this?

  • [X] I have searched the existing issues.

Command

No response

Description

It would be useful to have some way of specifying the order of filtering, e.g. that depends-on filtering should be applied to packages after include-dependencies is processed.

Currently, if I run something like this:

melos exec --concurrency=1 --fail-fast --scope="$(PACKAGE)" --include-dependencies --order-dependents --depends-on="build_runner" -- "make build"

It will exec command either on dependency of the scoped package or if the scoped package depends on build_runner.

Reasoning

We use depends-on to apply the command only to the subset of packages that depend on build_runner to generate the code, and it should be generated for all the dependencies as well, but only those that depend on build_runner.

Additional context and comments

No response

ookami-kb avatar Aug 11 '23 14:08 ookami-kb

Just linking this in here since it is related: #702

spydon avatar Aug 13 '24 08:08 spydon