globe icon indicating copy to clipboard operation
globe copied to clipboard

bug: if to add dot when creating a new project, it is not added to the actual project name

Open Shastel opened this issue 2 years ago • 5 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues.

CLI Version

N/A

Project ID

N/A

Description

When creating a new project it is allowed to put a dot (.) to the name of the project. UI will allow it, but when the project is actually created there is no dot in the name

Steps to reproduce

  1. Go to globe.dev and press 'create project'
  2. Import any project repo from GitHub
  3. Edit the project name to contain a dot (i.e. api.my-test-project)GitHub

Expected behavior

Either not allow it on UI, or use it in the name (and domain?)

Screenshots

No response

Additional context and comments

Note: Github allows to create repositories with dot in the name

Shastel avatar Dec 17 '23 12:12 Shastel

This isn't technically a bug. We slugify the name to become the project url, which we use for the dashboard, urls etc.

Probably need to change the wording here

Ehesp avatar Dec 17 '23 19:12 Ehesp

I'd also expect whatever name was used initially to match the one in created project. It shouldn't be very hard to validate project name upon creation.

lesnitsky avatar Dec 17 '23 20:12 lesnitsky

The idea was that it add less friction into the CLI flow, rather than trying to describe what is allowed/disallowed in the setup flow.

Ehesp avatar Dec 18 '23 11:12 Ehesp

Sorry, it seems that I was not clear. The issue is with globe.dev UI, not CLI. I never checked if this (or similar) is actual for CLI.

Shastel avatar Dec 18 '23 11:12 Shastel

Yeah that's my bad. Will add some validation on the frontend

Ehesp avatar Dec 18 '23 11:12 Ehesp