flutterfire_cli icon indicating copy to clipboard operation
flutterfire_cli copied to clipboard

ci: Use GitHub actions

Open spydon opened this issue 2 years ago • 6 comments

Description

This makes use of GitHub actions for the pipeline instead of separate scripts for each platform.

Type of Change

  • [x] ✅ ci -- Build configuration change

spydon avatar Jun 09 '22 20:06 spydon

Looks like this failed again on Windows but this seems to be from Pub now, probably another concurrency issue again 🤔 maybe @blaugold has some thoughts or is aware?

Salakar avatar Jun 22 '22 20:06 Salakar

Handling of error code 183 has been added in pub but is not in stable yet. This is the commit which rolled the fix into the Dart SDK repo: https://github.com/dart-lang/sdk/commit/2aa637afce62adeba7a70310a6577160bcb6d776

blaugold avatar Jun 22 '22 20:06 blaugold

Handling of error code 183 has been added in pub but is not in stable yet. This is the commit which rolled the fix into the Dart SDK repo: https://github.com/dart-lang/sdk/commit/2aa637afce62adeba7a70310a6577160bcb6d776

That's great, do you know if this was included in Dart 2.17.5?

spydon avatar Jun 29 '22 21:06 spydon

That's great, do you know if this was included in Dart 2.17.5?

I don't think so, unfortunately. Looks like this will land in 2.18.0.

blaugold avatar Jun 29 '22 21:06 blaugold

I don't think so, unfortunately. Looks like this will land in 2.18.0.

Ah too bad. How do you know when different commits will be released?

spydon avatar Jun 29 '22 21:06 spydon

I noticed that this specific commit adds to the changelog for 2.18.0 :)

blaugold avatar Jun 29 '22 21:06 blaugold

Since Dart 2.18.0 now is released, can we try re-running this? :)

spydon avatar Sep 19 '22 13:09 spydon

I see the Windows test isn't passing 🤔 But I cannot relaunch the CI, maybe @russellwheatley ?

Pushed an empty commit to force a re-run, but I forgot that the workflows require approval since I haven't had any PRs merged in this repo before. 😅

spydon avatar Sep 21 '22 07:09 spydon

Should be good 👍

Lyokone avatar Sep 21 '22 07:09 Lyokone