denque
denque copied to clipboard
Typings improvement.
I want to suggest some improvement on typings:
- Mark the
length
property as readonly since only getter is defined for this property. - I would use optional arguments syntax, e.g.
function foo(argument?: whatever) {}
instead on consequencial overloads since it's considered as a best practice. (https://github.com/invertase/denque/blob/master/index.d.ts#L4-L8)
We're willing to accept a PR to improve the types if you're interested?
Sure, i'll open a PR in a couple of days.