dart_firebase_admin icon indicating copy to clipboard operation
dart_firebase_admin copied to clipboard

feat: Implement verify method

Open KKimj opened this issue 1 year ago • 3 comments

Related Issues

fixes #20 #33 Thanks to @tkfinitefield

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).

  • [ ] I have updated the CHANGELOG.md of the relevant packages. Changelog files must be edited under the form:

    ## Unreleased fix/major/minor
    
    - Description of your change. (thanks to @yourGithubId)
    
  • [x] If this contains new features or behavior changes, I have updated the documentation to match those changes.

KKimj avatar Jul 30 '24 08:07 KKimj

As mentioned in the original PR, we'd want tests :)

rrousselGit avatar Jul 30 '24 11:07 rrousselGit

@rrousselGit

I'm having difficulty designing test scenarios when trying to write test code. I think testing the process of encoding and decoding a dummy JWT token might be a good approach, but I'm curious to hear your thoughts.

If you have the time, I'd be interested in collaborating on writing the tests. Thanks!

KKimj avatar Aug 01 '24 05:08 KKimj

are there any updates?

oikkoikk avatar Oct 04 '24 00:10 oikkoikk

I couldn't modify this PR so I created a new one: https://github.com/invertase/dart_firebase_admin/pull/54. The changes are mostly copied over except I tried to reuse the existing verifyJwtSignature function. The unit tests verify the 'kid' handling that is added to the verify function.

labrom avatar Oct 09 '24 21:10 labrom

Closing since there's a new PR

rrousselGit avatar Oct 10 '24 14:10 rrousselGit