dart_custom_lint
dart_custom_lint copied to clipboard
invertase
Fixes lingering issues to support workspaces in CLI
See https://github.com/invertase/dart_custom_lint/issues/298#issuecomment-2775420367
@Rexios80 is attempting to deploy a commit to the Invertase Team on Vercel.
A member of the Team first needs to authorize it.
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
To view this pull requests documentation preview, visit the following URL:
docs.page/invertase/dart_custom_lint~336
Documentation is deployed and generated using docs.page.
![docs-page[bot] avatar](https://avatars.githubusercontent.com/in/124461?v=4 "Published by a pub.dev verified publisher"){kind=small}
I am trying to write a test, but having a hard time getting it to work. This PR is more of a refactor than added functionality. The only code that might be questionable is adding followLinks: false since I thought there was already handling somewhere for that, but I was getting crashes in the ios symlinks folders.
Do you have any suggestions for where the test should go and other tests I should base it on?
Depends on how you want to implement the test.
I'm not fully understanding the issue that is being fixed here, so I don't know. But you can always write a e2e test and place it next to the other ones (the ones that start a process)
@rrousselGit Do you need anything more from me on this? Would like to get this merged soon so I can stop maintaining my own branch.
@Rexios80 Looks like you have some tests that failed. I assume those should be fixed if you want the PR merged.
The server_test fails on main, and the other tests all pass locally.
@rrousselGit I understand you being uninterested in maintaining this project because of major changes to the dart linting system, but many people and major packages are actively using it. I would be happy to take over if you gave me permissions. Otherwise I am seriously considering publishing my own fork which is not ideal since it fractures the ecosystem.
It looks like we are finally getting the new plugin system: https://github.com/dart-lang/sdk/blob/main/CHANGELOG.md#analyzer