dart_custom_lint icon indicating copy to clipboard operation
dart_custom_lint copied to clipboard

added severity to CLI output

Open praxder opened this issue 3 years ago • 9 comments

fixes #22

praxder avatar Aug 16 '22 18:08 praxder

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 16 '22 18:08 CLAassistant

Thanks a lot! Could you update the tests accordingly?

rrousselGit avatar Aug 16 '22 19:08 rrousselGit

I'm happy to update it! I'm new to contributing to this repo, so I'm sure I'm just missing something obvious, but whenever I try to run tests with dart test from the 'dart_custom_lint/packages/custom_lint' directory, I get a whole host of errors saying that it can't find the correct files. Here's one example: CleanShot 2022-08-16 at 16 33 53

What am I missing?

praxder avatar Aug 16 '22 21:08 praxder

It sounds like you're missing a "pub get" in those projects

rrousselGit avatar Aug 17 '22 07:08 rrousselGit

Thanks for the reply. I've tried that and the issue remains. The problem appears to be an incorrect path. The error message is saying that it's looking for 'package_config.json' at /Users/Smith/Developer/mobile/dart_custom_lint/packages/example_lint/.dart_tool/package_config.json

when in reality it exists at /Users/Smith/Developer/mobile/dart_custom_lint/packages/custom_lint/example/example_lint/.dart_tool/package_config.json

Is there an environment variable that I need to set perhaps? Or a different directory to run the tests from? I'm simply trying to run dart test from the 'dart_custom_lint/packages/custom_lint' directory.

praxder avatar Aug 17 '22 13:08 praxder

Could be a bug. The path you've described used to be correct, but we moved the example afterward.

Feel free to change the path :) That should hopefully be a simple fix

rrousselGit avatar Aug 17 '22 13:08 rrousselGit

Sounds good -- I'll work on that. Just wanted to make sure I wasn't missing something before making that change.

praxder avatar Aug 17 '22 14:08 praxder

It's hard to say without tests. Tests help the review process, as they help conceptualize what's actually added

rrousselGit avatar Aug 17 '22 15:08 rrousselGit

I fixed the paths to the tests, so now some of the tests run, but most still fail (14/17 tests still fail).

praxder avatar Aug 27 '22 16:08 praxder

Sorry for the delay. I've fixed the main branch. If you still want this, feel free to sync your branch with main and try again :)

rrousselGit avatar Nov 17 '22 14:11 rrousselGit