inversify-express-utils
inversify-express-utils copied to clipboard
inversify
Adequate support for stream responses
Added functionality of piping streamed responses without having to return callback with pipe in it
Description
Created new content type of StreamContent and added proper handle for it in server.ts on return
Related Issue
https://github.com/inversify/InversifyJS/issues/850
Motivation and Context
Fixes the bug
How Has This Been Tested?
Unit test were written.
Types of changes
- [x] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
Checklist:
- [x] My code follows the code style of this project.
- [x] My change requires a change to the documentation.
- [x] I have updated the documentation accordingly.
- [x] I have read the CONTRIBUTING document.
- [x] I have added tests to cover my changes.
- [x] All new and existing tests passed.
@Foxy-Loxy will you please update this PR and resolve the conflicts? Thank you
@dcavanagh , sorry for long delay in answer. I though that project is no longer maintained so never checked on PR. I did conflict resolvment and adapted new linter styles. Feel free to add any more inputs.
@dcavanagh, I'm not sure if it's still relevant, but I've updated code to resolve all conflicts. Would be really cool if you, or anyone from maintainers would have time to check this out :)
@dcavanagh after we merge this, can we also release with w/e is on master ? It's been a very long time since we haven't released.
@bhupesh-sf I have added this to 6.5.0 milestone and it will be published in the next release, I will aim to make a release this week. Thank you and apologies for the delay.
