inversify-binding-decorators icon indicating copy to clipboard operation
inversify-binding-decorators copied to clipboard

Add inRequestScope decorator inversify/InversifyJS/issues/678

Open timtrinidad opened this issue 7 years ago • 6 comments

Description

This adds inRequestScope support in fluentProvide.

Related Issue

inversify/InversifyJS/issues/678

How Has This Been Tested?

  • Updated tests that included inSingletonScope and inTransientScope to also include inRequestScope.
  • provide_in_syntax.test.ts refactored to reduce duplicate code.

Types of changes

  • [ ] Bug fix / Docs (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [x] I have added tests to cover my changes.
  • [x] All new and existing tests passed.

timtrinidad avatar Sep 25 '18 19:09 timtrinidad

@remojansen Just wanted to ping to see if there was anything else needed for this PR

timtrinidad avatar Jan 04 '19 22:01 timtrinidad

@dcavanagh Hey Dan! Would something like this go through you now?

timtrinidad avatar Apr 22 '19 15:04 timtrinidad

@remojansen @dcavanagh I'm also interested in this PR! Is there something that I can help?

glanna avatar Feb 07 '22 17:02 glanna

@jakehamtexas do you see any problems here, seems good to me at a first look.

PodaruDragos avatar Jul 12 '22 18:07 PodaruDragos

hi guys, can we merge this change in?

gustavolanna avatar Sep 01 '22 18:09 gustavolanna

Hmm inversify seems to be a dead project :( I mean this PR is from 2018.. Just merge it already.

adamxi avatar Oct 10 '23 13:10 adamxi