packetfence icon indicating copy to clipboard operation
packetfence copied to clipboard

Feature/fingerbank via connector

Open julsemaan opened this issue 2 years ago • 3 comments

Description

Adds support for the Fingerbank Collector on a pfconnector-remote instance

Impacts

Fingerbank in PacketFence

Code / PR Dependencies

Needs the pfconnector-remote debian packaging to work #7232

NEW Package(s) required

fingerbank-collector-1.4.1 and fingerbank-collector-remote-1.4.1 (both in devel repos)

Delete branch after merge

YES

Checklist

(REQUIRED) - [yes, no or n/a]

  • [X] Document the feature
  • [N/A] Add unit tests
  • [X] Add acceptance tests (TestLink)

NEWS file entries

(REQUIRED, but may be optional...)

New Features

  • Added support for the Fingerbank Collector on a PacketFence connector

julsemaan avatar Oct 06 '22 18:10 julsemaan

TODO

  • [ ] High level schema for how it works
  • [x] Add fingerbank-collector-remote as a dependency to packetfence-pfconnector-remote

julsemaan avatar Oct 06 '22 18:10 julsemaan

Looks good so far. What is the best way to test?

jrouzierinverse avatar Oct 07 '22 14:10 jrouzierinverse

Looks good so far. What is the best way to test?

It's pretty manual now since the packaging for the pfconnector-remote is not completed yet but here are the general guidelines

  • Install the pfconnector-remote from this branch
  • Install fingerbank-collector-remote
  • Connect your pfconnector-remote to PF
  • Test some stuff related to Fingerbank for a node behind the pfconnector-remote

julsemaan avatar Oct 11 '22 12:10 julsemaan

@fdurand and @jrouzierinverse, can you provide a review of the code?

Thanks!

julsemaan avatar Oct 26 '22 15:10 julsemaan