packetfence icon indicating copy to clipboard operation
packetfence copied to clipboard

Captive Portal - Deprecate jQuery

Open satkunas opened this issue 2 years ago • 4 comments

Description

  • remove jQuery (and prototype) from html/captive-portal, html/common
  • replace qrcode dependency w/ no sub-dependancies

Impacts

  • May impact older browser compatibility.
  • Captive Portal workflows not tested during removal.

Code / PR Dependencies

none

Delete branch after merge

YES

Checklist

  • [ ] Document the feature
  • [ ] Add unit tests
  • [ ] Add acceptance tests (TestLink)

Bug Fixes

  • Fixes #7131

Enhancements

  • Removed jQuery dependency in captive portal.

satkunas avatar Sep 16 '22 19:09 satkunas

Browser support w/ replacement fn's

Screen Shot 2022-09-16 at 4 36 36 PM

satkunas avatar Sep 16 '22 20:09 satkunas

Browser support w/ replacement fn's

Screen Shot 2022-09-16 at 4 36 36 PM

Did you implement a check in the portal where if a device doesn't meet the new requirements, it will show a very clear warning at the top of the portal page?

julsemaan avatar Sep 20 '22 16:09 julsemaan

Browser support w/ replacement fn's Screen Shot 2022-09-16 at 4 36 36 PM

Did you implement a check in the portal where if a device doesn't meet the new requirements, it will show a very clear warning at the top of the portal page?

There currently appears to be a mechanism to display such a message. I did not review its function.

satkunas avatar Sep 21 '22 12:09 satkunas

Browser support w/ replacement fn's Screen Shot 2022-09-16 at 4 36 36 PM

Did you implement a check in the portal where if a device doesn't meet the new requirements, it will show a very clear warning at the top of the portal page?

There currently appears to be a mechanism to display such a message. I did not review its function.

This needs to be added to this PR as its a hard requirement for getting this in the hands of customers so that JS issues don't go silently and the portal is just broken without any feedback

julsemaan avatar Sep 21 '22 12:09 julsemaan