packetfence
packetfence copied to clipboard
Captive Portal - Deprecate jQuery
Description
- remove jQuery (and prototype) from
html/captive-portal
,html/common
- replace qrcode dependency w/ no sub-dependancies
Impacts
- May impact older browser compatibility.
- Captive Portal workflows not tested during removal.
Code / PR Dependencies
none
Delete branch after merge
YES
Checklist
- [ ] Document the feature
- [ ] Add unit tests
- [ ] Add acceptance tests (TestLink)
Bug Fixes
- Fixes #7131
Enhancements
- Removed jQuery dependency in captive portal.
Browser support w/ replacement fn's
Browser support w/ replacement fn's
Did you implement a check in the portal where if a device doesn't meet the new requirements, it will show a very clear warning at the top of the portal page?
Browser support w/ replacement fn's
Did you implement a check in the portal where if a device doesn't meet the new requirements, it will show a very clear warning at the top of the portal page?
There currently appears to be a mechanism to display such a message. I did not review its function.
Browser support w/ replacement fn's
Did you implement a check in the portal where if a device doesn't meet the new requirements, it will show a very clear warning at the top of the portal page?
There currently appears to be a mechanism to display such a message. I did not review its function.
This needs to be added to this PR as its a hard requirement for getting this in the hands of customers so that JS issues don't go silently and the portal is just broken without any feedback