packetfence icon indicating copy to clipboard operation
packetfence copied to clipboard

Handle WebAuth on Extreme Controller without web form

Open nqb opened this issue 2 years ago • 4 comments

Description

Handle WebAuth on Extreme Controller without web form

Web form usage still work but some browsers complain when they have to send a web form to 1.1.1.1/reg.php using HTTP (in place of HTTPS). Switching to HTTPS break everything.

Delete branch after merge

YES

NEWS file entries

Enhancements

  • Improve WebAuth support on Extreme controllers

nqb avatar Aug 10 '22 10:08 nqb

Not sure if I need to add a dedicated URL for WebAuth in constants.pm

nqb avatar Aug 10 '22 11:08 nqb

Not sure if I need to add a dedicated URL for WebAuth in constants.pm

I believe you do since your configuration in the Extreme controller will be to point the webauth URL to /Extreme::Extreme_Controller so that URL must be allow-listed by being in pf::web::constants

julsemaan avatar Aug 10 '22 12:08 julsemaan

I made some adjustments and tests: it works as expected.

I need some confirmation from Extreme then we can merge (for v12 ?) if you agree.

I can also add some documentation.

nqb avatar Aug 11 '22 09:08 nqb

I do think we need some doc on configuring this or at the very least a link to some existing external doc we can follow that gives the right result.

I do think it's mergeable for v12 given it has a very little footprint and is self-contained

julsemaan avatar Aug 11 '22 11:08 julsemaan

@nqb, do you think you will be able to add some doc to this? Or link to a documentation published by Extreme we could follow for the controller/AP config?

julsemaan avatar Oct 25 '22 14:10 julsemaan

I will do my best to provide this and get this PR merged for 12.1.0

nqb avatar Oct 25 '22 19:10 nqb

Doc added, I checked AsciiDoctor display and it looks good.

I also change name of module to be close to what we have for Aerohive.

nqb avatar Oct 26 '22 14:10 nqb

@julsemaan, do a final review and merge

julsemaan avatar Oct 27 '22 13:10 julsemaan

Minor verbiage stuff in the docs, since @nqb is off, I'll apply them and merge

julsemaan avatar Oct 28 '22 15:10 julsemaan