packetfence icon indicating copy to clipboard operation
packetfence copied to clipboard

fix/6088

Open jrouzierinverse opened this issue 5 years ago • 7 comments

Description

Avoid looking up a mac lookup when bouncing a port when the mac is known.

Impacts

Bouncing ports

NEWS file entries

Bug Fixes

  • Bounce the correct node when bounce a port.

Issue

fixes #6088

Delete branch after merge

NO

Checklist

  • [ ] Document the feature
  • [x] Add unit tests
  • [ ] Add acceptance tests (TestLink)

jrouzierinverse avatar Jan 14 '21 11:01 jrouzierinverse

What about: lib/pf/UnifiedApi/Controller/Nodes.pm - sub do_restart_switchport lib/pf/api.pm - sub _reassignSNMPConnections

lyubomirtraykov avatar Jan 14 '21 13:01 lyubomirtraykov

Not really agree with this PR. setAdminStatus is a SNMP based function and now we use it for CoA.

We should first use something like _bouncePortCoa here https://github.com/inverse-inc/packetfence/pull/6095/files#diff-7846c679ffe675238b4ec682eb6ed4537c7de86e1dfb409781b3b9a3d0f71ceeR196 and only keep the $mac extra parameter to bouncePort.

fdurand avatar Jan 14 '21 13:01 fdurand

@lyubomirtraykov Those are done.

What about: lib/pf/UnifiedApi/Controller/Nodes.pm - sub do_restart_switchport https://github.com/inverse-inc/packetfence/pull/6095/files#diff-eb948d5c38b649c38bfc137f7a900e3ca6821bab3921e7b2789d22fd9b182f1eR321 lib/pf/api.pm - sub _reassignSNMPConnections https://github.com/inverse-inc/packetfence/pull/6095/files#diff-e490a9d11b45d4ab09c73e81fcefb4a890dcd5dcc72b3778ca08531267c3e6a6R472

jrouzierinverse avatar Jan 14 '21 14:01 jrouzierinverse

@fdurand setAdminStatus was already using radius calls for the following modules. lib/pf/Switch/Juniper/EX2300.pm lib/pf/Switch/Pica8.pm This PR does not change that.

jrouzierinverse avatar Jan 14 '21 14:01 jrouzierinverse

Will this fix be merged before 10.3 release?

lyubomirtraykov avatar Apr 14 '21 12:04 lyubomirtraykov

no

nqb avatar Apr 14 '21 13:04 nqb

Will this be merged anytime soon?

lyubomirtraykov avatar Feb 17 '22 10:02 lyubomirtraykov