packetfence icon indicating copy to clipboard operation
packetfence copied to clipboard

default SMS source: sms_carriers option

Open nqb opened this issue 6 years ago • 5 comments

sms_carriers option should include all the SMS carriers in DB.

It looks like the latest additions in DB haven't been added in conf/authentication.conf

nqb avatar Dec 24 '18 09:12 nqb

Yeah this is because we reference the SMS carriers in authentication.conf as well.

We have 2 choices:

  1. We adjust authentication.conf.example
  2. We support making the sms_carriers empty and when its the case, it displays all the carriers in the DB

Would be cleaner to do option 2 and it would be future-proof

julsemaan avatar Dec 27 '18 12:12 julsemaan

In option 2, admin can select SMS carriers in a dropdown list in the auth source.

However, if they don't, the default sms source will not work: guest can't select a provider which has not been defined in the source.

nqb avatar Jan 02 '19 13:01 nqb

This is why we need to change the backend code to magically fill in all the carriers when the list is empty

julsemaan avatar Jan 03 '19 13:01 julsemaan

@nqb Please add manually the ones that are missing and open a PR.

extrafu avatar Jan 04 '19 15:01 extrafu

For 8.3, I fixed missing sms_carriers in 7a1af6c

nqb avatar Jan 04 '19 15:01 nqb