email template: unexpected behavior with default sponsor source

[nqb]

When you use the default sponsor source (with no mandatory fields other than the guest's email), emails sent to sponsor will be unclear due to missing firstname/lastname fields:

In this situation, template should use guest's email address at beginning of the sentence.

[mendoza-conicet]

It also presents problems with the "Activate Access" button. it does not write the activation_uri variable, which makes it impossible to use this feature. It seems to me that I should have a higher priority.

[nqb]

@mendoza-conicet: 8.3 version ? Apply maintenance patches and retry..

[mendoza-conicet]

@nqb i'm using 8.3, after apply maintenance patches work well!

[jrouzierinverse]

This seems to be fixed can we close?

[nqb]

Reopening, issue still presents.

[jrouzierinverse]

@nqb should #7069 close this one also?

[nqb]

@jrouzierinverse, I look quickly but it seems that this issue is caused by the fact that html/captive-portal/templates/emails/emails-guest_sponsor_activation.html use firstname and lastname before the word "requested".

Because these fields are empty (as you can see on the screenshot), there is nothing to display.

IMHO, if we use a tag like firstname and lastname in an email template, we need to be sure these fields are mandatory in the form where we asked them. So I don't think #7069 solve this use case.