InvenTree icon indicating copy to clipboard operation
InvenTree copied to clipboard

Remove need to run invoke update after docker pull

Open matmair opened this issue 1 year ago • 12 comments

This PR adds a new script contrib/container/execute.sh that checks if the API version of the starting image is different to the last checked version of the host and triggers invoke update automatically.

Fork details of 6305

Adoption of #6305, keeping the original commit by @ChristianSchindler to give co-authorship.

Removes the section we would not merge due to the comments brought up in https://github.com/inventree/InvenTree/pull/6305#issuecomment-1903817520. Keeps the great implementation of a database version check and auto-run of inv update - making docker setup much easier.

Ref #6303

matmair avatar Feb 19 '24 23:02 matmair

Deploy Preview for inventree-web-pui-preview ready!

Name Link
Latest commit 8d8fbd43a71ffc11d337a6793785d6dcf169befa
Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/66c8aba5202d6600086ee828
Deploy Preview https://deploy-preview-6524--inventree-web-pui-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 92 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Feb 19 '24 23:02 netlify[bot]

For the db_version we shud properly replace it with InvenTree/InvenTree/version.py and ther shut also be a possibility to deactivate auto update with an environment variable

ChristianSchindler avatar Feb 19 '24 23:02 ChristianSchindler

This will have to be pushed to 0.15.0, the release window for 0.14.0 is to close

matmair avatar Feb 26 '24 00:02 matmair

@matmair can we use InvenTree/InvenTree/version.py for getting the version?

ChristianSchindler avatar Mar 04 '24 22:03 ChristianSchindler

This is working on my dev setup; would be happy for a review / general options @wolflu05 @SchrodingersGat

matmair avatar Aug 20 '24 11:08 matmair

  • and skipping backup, mh, maybe, but I dont think that hurts

Personally I have to skip it because I use an unsupported version of postgres (postgres:16) and this is the only thing what is not working

ChristianSchindler avatar Aug 23 '24 15:08 ChristianSchindler

I do not plan to support unsupported configs

matmair avatar Aug 23 '24 15:08 matmair

I do not plan to support unsupported configs

That is way I only find it good to have the same possibly in the container as without it. I think you had also different reasons way you cracked this options for this script I do not think about

ChristianSchindler avatar Aug 23 '24 15:08 ChristianSchindler