InvenTree icon indicating copy to clipboard operation
InvenTree copied to clipboard

Add "ON HOLD" status to orders

Open SchrodingersGat opened this issue 1 year ago • 4 comments

A new "status" flag for orders (build, sales, purchase, return) which allows them to be marked as "on hold".

Not closed out, but designated as not currently active (perhaps waiting for input)

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar

SchrodingersGat avatar Feb 16 '24 03:02 SchrodingersGat

@SchrodingersGat would this flag stop changes from occuring?

matmair avatar Feb 16 '24 07:02 matmair

We would have to consider the allowed state transitions here. Have not yet fully thought it through

SchrodingersGat avatar Feb 16 '24 08:02 SchrodingersGat

Hi,

would it also be possible to add In Test and Internal to the status for parts? I currently use Quarentine to identify if a parts is in test. so in my case Boards come in, then they are added to the stock but. they can only be sold once availeble. and prior to getting this order i run an intake test for each board. hence this status would be nice.

mabroens avatar Mar 09 '24 13:03 mabroens

I think the default set of states should not be too large and each option should have business logic connected to it. So maybe one of the two options is fine but cluttering th UI with options that have basically the same function seems more confusing than helping.

Without a proper definition of the logic there is not enough info the dev something either way.

matmair avatar Mar 11 '24 20:03 matmair

I would like to implement this soon, as I have a need for it. There are two potential ways to implement this, and I'd like some feedback on how we would like to see it done.

Option A: New Status Code

Add a new "ON_HOLD" status code to each type of order. This means that the order must transition to a new "ON_HOLD" state, which is very visible and the order cannot be "in progress" and "on hold" at the same time.

This would require careful consideration of state transitions for each order, but is probably (IMO) the more robust approach

Option B: Separate Field

Add a separate "ON HOLD" boolean field to the Order model, which is a simpler approach. However this is potentially confusing if the "on hold" flag is set for an order which is "complete" or "cancelled" etc.


Thoughts?

SchrodingersGat avatar Aug 02 '24 02:08 SchrodingersGat

I would prefer option A as its more clear in its state. But in the end the importance for me is that we can simply filter them out in the overview

Met vriendelijke groet/ With kind regards, Martijn Broens

From: Oliver @.> Sent: Friday, August 2, 2024 4:03 AM To: inventree/InvenTree @.> Cc: Martijn Broens @.>; Comment @.> Subject: Re: [inventree/InvenTree] Add "ON HOLD" status to orders (Issue #6504)

I would like to implement this soon, as I have a need for it. There are two potential ways to implement this, and I'd like some feedback on how we would like to see it done.

Option A: New Status Code

Add a new "ON_HOLD" status code to each type of order. This means that the order must transition to a new "ON_HOLD" state, which is very visible and the order cannot be "in progress" and "on hold" at the same time.

This would require careful consideration of state transitions for each order, but is probably (IMO) the more robust approach

Option B: Separate Field

Add a separate "ON HOLD" boolean field to the Order model, which is a simpler approach. However this is potentially confusing if the "on hold" flag is set for an order which is "complete" or "cancelled" etc.


Thoughts?

— Reply to this email directly, view it on GitHubhttps://github.com/inventree/InvenTree/issues/6504#issuecomment-2264358893, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A7DP63HRD3AF64J572IB7CLZPLSGBAVCNFSM6AAAAABDLKMYXCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRUGM2TQOBZGM. You are receiving this because you commented.Message ID: @.@.>>

mabroens avatar Aug 02 '24 06:08 mabroens

Without a full definition of the transitions and business logic behind them it is hard to tell which would be suited better but probably option A

matmair avatar Aug 02 '24 21:08 matmair