inventree
Fixing Header to rely on location and not parameter.
Closes #6471 Fixes issue #6471
Let me check the commit test server thing to see if it's working before it's merged.
Deploy Preview for inventree-web-pui-preview ready!
| Name | Link |
|---|---|
| Latest commit | fa1cb1b71524191f38547893526f92ddc8ef895c |
| Latest deploy log | https://app.netlify.com/sites/inventree-web-pui-preview/deploys/65ca2b3ed1144d000858d25e |
| Deploy Preview | https://deploy-preview-6472--inventree-web-pui-preview.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
Lighthouse |
1 paths audited Performance: 100 (no change from production) Accessibility: 86 (no change from production) Best Practices: 100 (no change from production) SEO: 70 (no change from production) PWA: - View the detailed breakdown and full score reports |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
^ The commit test server thing translates to Deploy Preview. It appears to work; however, I am slightly confused as to what the Style error is telling me.
I see; it was telling me what to change, not what the issue was. Got it!
How important is it that the current "top level tab" is indicated in this fashion? There are many pages (e.g. settings / notifications / etc) which do not even fit under this scheme.
The <Tabs> component makes sense for switching between content within a single page, but maybe feels like the wrong solution for global path navigation...
Thoughts?
Personally I really like this navigation to switch between the core parts of InvenTree and would miss it if it would be removed.
To be clear I am not talking about removing the tabs themselves - just the "current tab" indicator (unless we can work out a good way to implement)
I am bumping this to 0.15.0 until we have some consensus on a sensible solution
@CodingPupper3033 could you adress the merge conflict so we can get this into 0.16.0?
