InvenTree icon indicating copy to clipboard operation
InvenTree copied to clipboard

Add support for a Completed status (Fixes: #6434)

Open tsimonq2 opened this issue 1 year ago • 7 comments

Per #6434 (filed by my colleague at Altispeed), this is the user interface and backend state. This does piggyback off of some existing shipped functionality, but does work.

tsimonq2 avatar Feb 07 '24 22:02 tsimonq2

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
Latest commit 2629ab9ababade9cf830a4e9c36aba23e032e914
Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/66456014173b99000868634e

netlify[bot] avatar Feb 07 '24 22:02 netlify[bot]

@tsimonq2 looks like you know what you are doing! LMK if you need any specific pointers :)

SchrodingersGat avatar Feb 08 '24 04:02 SchrodingersGat

@tsimonq2 any progress on this? I'd like to see this integrated and not get lost to the sands of time :)

SchrodingersGat avatar Mar 15 '24 01:03 SchrodingersGat

@tsimonq2 any progress on this? I'd like to see this integrated and not get lost to the sands of time :)

I know this is still on @tsimonq2 list of dev projects. He is currently assigned a pretty big project of developing a parcel tracking software so this may take a while to get to but we will make sure it gets added as once we get this feature added to Inventree we will be implementing it at our company.

altispeedkschmidt avatar Mar 15 '24 20:03 altispeedkschmidt

@SchrodingersGat How does this look? It works :smile:

tsimonq2 avatar Mar 20 '24 22:03 tsimonq2

@tsimonq2 are you able to address the failing QI issues as above?

SchrodingersGat avatar Apr 11 '24 11:04 SchrodingersGat

@tsimonq2 if you were able to get back to this soon, it could still make the next release cycle. Please let me know.

SchrodingersGat avatar May 12 '24 13:05 SchrodingersGat

Codecov Report

Attention: Patch coverage is 86.36364% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 84.04%. Comparing base (548ecf5) to head (2629ab9). Report is 1 commits behind head on master.

Files Patch % Lines
src/backend/InvenTree/order/models.py 80.00% 2 Missing :warning:
src/backend/InvenTree/order/serializers.py 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6449      +/-   ##
==========================================
- Coverage   84.05%   84.04%   -0.01%     
==========================================
  Files        1053     1054       +1     
  Lines       46256    46268      +12     
  Branches     1337     1337              
==========================================
+ Hits        38879    38888       +9     
- Misses       7052     7055       +3     
  Partials      325      325              
Flag Coverage Δ
backend 85.45% <86.36%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 16 '24 01:05 codecov[bot]

@SchrodingersGat Should be all set now :)

tsimonq2 avatar May 16 '24 01:05 tsimonq2

@tsimonq2 many thanks for the contribution :)

SchrodingersGat avatar May 16 '24 02:05 SchrodingersGat

@SchrodingersGat this needs to be called out as breaking for plugins that call complete_order in the release notes as the effect changes

matmair avatar May 16 '24 06:05 matmair