InvenTree icon indicating copy to clipboard operation
InvenTree copied to clipboard

Remove django-allauth-2fa

Open matmair opened this issue 1 year ago β€’ 3 comments

This PR remove django-allauth-2fa and replaces it with the inline functions of django-allauth. This reduces the depenecdy footprint and sets us up for further improvements that are planned upstream. Those will reduce the dependency footprint even more and close #4002

Closes #6281

matmair avatar Jan 19 '24 17:01 matmair

Deploy Preview for inventree-web-pui-preview ready!

Name Link
Latest commit 8fad7b1e1fbd3ffc7355fdb9c8ebee757d45efce
Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/667be908720eb900084e46b8
Deploy Preview https://deploy-preview-6293--inventree-web-pui-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 92 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jan 19 '24 17:01 netlify[bot]

Codecov Report

Attention: Patch coverage is 61.53846% with 20 lines in your changes missing coverage. Please review.

Project coverage is 85.53%. Comparing base (c9e9ef1) to head (843fdc9). Report is 6 commits behind head on master.

:exclamation: Current head 843fdc9 differs from pull request most recent head 8fad7b1

Please upload reports for the commit 8fad7b1 to get more accurate results.

Files Patch % Lines
src/backend/InvenTree/users/test_migrations.py 27.77% 13 Missing :warning:
...users/migrations/0012_migrate_mfa_20240408_1659.py 66.66% 7 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6293      +/-   ##
==========================================
+ Coverage   84.10%   85.53%   +1.42%     
==========================================
  Files        1066      900     -166     
  Lines       46662    41227    -5435     
  Branches     1396      325    -1071     
==========================================
- Hits        39244    35262    -3982     
+ Misses       7055     5927    -1128     
+ Partials      363       38     -325     
Flag Coverage Ξ”
backend 85.23% <61.53%> (-0.10%) :arrow_down:
migrations 42.48% <61.53%> (-0.01%) :arrow_down:
pui 44.03% <ΓΈ> (-21.46%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 08 '24 16:04 codecov[bot]

Upstream is not supporting enforced MFA right now - postboning to 0.16.0

matmair avatar Apr 28 '24 21:04 matmair

OK MFA enforcing can be build by us and upstreamed but https://github.com/pennersr/django-allauth/issues/3830 is a new blocking

matmair avatar Jun 25 '24 18:06 matmair

Site-Note: It seems I always end up ripping out/replacing the features I write

matmair avatar Jun 25 '24 19:06 matmair