InvenTree icon indicating copy to clipboard operation
InvenTree copied to clipboard

Fix for string form fields

Open SchrodingersGat opened this issue 1 month ago β€’ 4 comments

  • replace null values with empty strings
  • Ensure that strings are not replaced with null values sometimes

SchrodingersGat avatar Nov 13 '25 06:11 SchrodingersGat

Deploy Preview for inventree-web-pui-preview ready!

Name Link
Latest commit 33f0c7d20647f0758d3be3b2186d8678169d5962
Latest deploy log https://app.netlify.com/projects/inventree-web-pui-preview/deploys/69340f97693cde0008fcd4b0
Deploy Preview https://deploy-preview-10814--inventree-web-pui-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 94 (🟒 up 1 from production)
Accessibility: 81 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Nov 13 '25 06:11 netlify[bot]

We have to carefully consider this change, I'm not really sure if this does not break something.

wolflu05 avatar Nov 13 '25 07:11 wolflu05

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 87.98%. Comparing base (3a18934) to head (33f0c7d). :warning: Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10814      +/-   ##
==========================================
- Coverage   88.17%   87.98%   -0.19%     
==========================================
  Files        1289     1290       +1     
  Lines       58051    58101      +50     
  Branches     1973     1973              
==========================================
- Hits        51184    51123      -61     
- Misses       6376     6487     +111     
  Partials      491      491              
Flag Coverage Ξ”
backend 89.47% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Ξ”
Backend Apps 91.77% <ΓΈ> (-0.26%) :arrow_down:
Backend General 93.12% <ΓΈ> (-0.36%) :arrow_down:
Frontend 70.87% <ΓΈ> (-0.01%) :arrow_down:
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Nov 13 '25 07:11 codecov[bot]

@wolflu05 I have added some extra checks here, it will only overwrite a null value if the serializer does not allow null values

SchrodingersGat avatar Nov 13 '25 11:11 SchrodingersGat

πŸ’š All backports created successfully

Status Branch Result
βœ… 1.1.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

github-actions[bot] avatar Dec 06 '25 11:12 github-actions[bot]