django-image-uploader-widget icon indicating copy to clipboard operation
django-image-uploader-widget copied to clipboard

adaptat to accept, preview and render videos

Open dmp593 opened this issue 1 year ago • 3 comments

Hi @EduardoJM,

I loved your project. It perfectly suits my needs for my admin website, and I'm very grateful for your contribution.

However, I made a few small changes to match the current specifications, as my client also uploads videos and wants to see previews.

I am considering modifying the project to support chunked uploads, as videos often lead to a 413 Entity Too Large response.

For now, that’s it!

I'm sorry I didn't add any tests. I'm not familiar with the tool you used to build the project. I am accustomed to using Poetry, but this pyproject seemed to use a different tool.

So, for now, I just installed the dependencies into a local virtual environment using pip.

Could you please explain how to set up the project and run the tests?

Once again, I am very grateful for this gem of a project.

Best regards, Daniel Pinto.

dmp593 avatar Jul 03 '24 10:07 dmp593

By the way, I fixed a bug in your library that caused the image/video asset to render regardless of whether an image or video was present. This issue occurred when the response was a bad request due to errors in some form fields. Consequently, it created an inconsistent state where the form could not be submitted because the input files had a null value.

dmp593 avatar Jul 03 '24 16:07 dmp593

Hello! Sorrry for the long wait time,

I will test and verify the changes and validate this to this project.

Maybe, we can add support, in the future, for other files too, likely a little bit modern file uploader.

EduardoJM avatar Jul 24 '24 14:07 EduardoJM

Thank you so much! :D

dmp593 avatar Jul 26 '24 13:07 dmp593

After some time thinking about this and the future of all django projects maintained by us, we decided that this package should only support image uploader widget and not other media types for now.

EduardoJM avatar Oct 17 '24 17:10 EduardoJM

@dmp593 I was looking for a widget to support video and image previews and found your PR. I tested it and it was amazing, thanks for your efforts

bigsbug avatar Dec 25 '24 15:12 bigsbug

@dmp593 I was looking for a widget to support video and image previews and found your PR. I tested it and it was amazing, thanks for your efforts

Hey, I'm so glad to hear this! Thank you a lot! <3

Happy New Year btw 🎉

dmp593 avatar Jan 02 '25 10:01 dmp593