bibcirculation: Not possible to set a due date manually

[aw-bib]

There seem to be several issues in the set due date functionality, ie the manual overwrite of due dates by library staff.

1. From the patrons page:
   • select action / Change due date causes a 500. This error results from an (at least now) invalid SQL statement in get_loan_infos(), where an unused table is referenced and thus leeds to a None result.
2. From the items page:
   • select action / Change due date causes a 500. This error results from a wrong parameter passed to the backend (barcode instead of loan_id).
3. Finally, once the above is done, changing the due date in tmpl_change_due_date_step1() has no effect, as the input field defined in l.7936 has a wrong name. It has to be due_date not period_from.

The second and third bug can be solved in bibcirculation_templates, e.g. by introducing named parameters and the proper name respectively, when building the necessary HTML.

The first error seems to require intervention in bibcirculation_dblayer.py, l.1916 where , crcLOANREQUEST lr requires removal. This fix will then solve a subsequent error that would appear in case two if parameters were passed on properly.

isIdenticalTo: join2/join2#935

[lnielsen]

cc @egabancho @tiborsimko @kaplun

[aw-bib]

Note: we run 1.1.7. Might not be relevant upstream anymore.