invenio icon indicating copy to clipboard operation
invenio copied to clipboard

WebStyle: fix two regression test cases

Open tiborsimko opened this issue 11 years ago • 7 comments

Originally on 2013-02-11

After introduction of goto handler in c2076bb4be706f6cd95f0ced99d36f827434ed45, two tests were commented out, test_latest_pdf_article_redirection() and test_URL_argument_in_redirection() in the regression test suite. This needs fixing.

tiborsimko avatar Apr 30 '14 15:04 tiborsimko

Originally on 2013-02-11

In d29010ef76a8420d02a55c4096ce986bae59ec74:

#CommitTicketReference repository="invenio" revision="d29010ef76a8420d02a55c4096ce986bae59ec74"
WebStyle: inactivate two regression tests

- Inactivates two regression tests that need fixing.
  (see #1293)

tiborsimko avatar May 01 '14 02:05 tiborsimko

Originally on 2013-02-12

In d29010ef76a8420d02a55c4096ce986bae59ec74:

#CommitTicketReference repository="invenio" revision="d29010ef76a8420d02a55c4096ce986bae59ec74"
WebStyle: inactivate two regression tests

- Inactivates two regression tests that need fixing.
  (see #1293)

tiborsimko avatar May 01 '14 02:05 tiborsimko

Originally on 2013-02-18

Tha attached patch fixes the regression tests.

kaplun avatar May 01 '14 02:05 kaplun

Was it fixed? Otherwise perhaps remove it from the milestone.

lnielsen avatar Sep 05 '14 09:09 lnielsen

@lnielsen-cern Nope, it was not fixed yet. As this is a test case failure, I'm raising severity to critical.

$ git grep test_URL_argument_in_redirection
modules/webstyle/lib/webstyle_regression_tests.py:    def FIXME_TICKET_1293_test_URL_argument_in_redirection(self):

tiborsimko avatar Sep 05 '14 12:09 tiborsimko

Is this still relevant? Is CDS still using the Goto functionality? @ludmilamarian @egabancho @switowski

kaplun avatar Jan 05 '17 10:01 kaplun

we are using the goto

ludmilamarian avatar Jan 05 '17 11:01 ludmilamarian