invenio-app-rdm icon indicating copy to clipboard operation
invenio-app-rdm copied to clipboard

Incorrect error handling in resource layer

Open jrcastro2 opened this issue 1 year ago • 2 comments

At the moment we are catching low levels exceptions suchs as NoResultFound in the resource layer, that can potentially hide issues. The service layer should catch the exception when resolving the record and raise a proper error that can be caught in the resource layer.

See here example: https://github.com/inveniosoftware/invenio-app-rdm/blob/master/invenio_app_rdm/records_ui/views/decorators.py#L175

Here original comment: https://github.com/inveniosoftware/invenio-rdm-records/pull/1604/files#r1394256328

jrcastro2 avatar Nov 16 '23 13:11 jrcastro2

This issue was automatically marked as stale.

github-actions[bot] avatar Jan 16 '24 06:01 github-actions[bot]

This issue was automatically marked as stale.

github-actions[bot] avatar Mar 17 '24 06:03 github-actions[bot]