invenio-app-rdm icon indicating copy to clipboard operation
invenio-app-rdm copied to clipboard

header: updated quick actions dropdown.

Open alejandromumo opened this issue 1 year ago • 9 comments

closes https://github.com/zenodo/rdm-project/issues/486

alejandromumo avatar Nov 01 '23 13:11 alejandromumo

Result:

Unauthenticated users

Screenshot at Nov 01 14-06-59

If the user clicks "New upload" or "New community", they're redirected to the login page

Authenticated users

Screenshot at Nov 01 14-06-49

alejandromumo avatar Nov 01 '23 13:11 alejandromumo

Can you keep the original menu item text:

  • New upload
  • New community

Also the caret down icon is missing after the ...

lnielsen avatar Nov 02 '23 08:11 lnielsen

Can you keep the original menu item text:

* New upload

* New community

Also the caret down icon is missing after the ...

Screenshot at Nov 02 10-04-29

alejandromumo avatar Nov 02 '23 09:11 alejandromumo

small suggestion: could you increase a distance between + and New ? it seems a little bit too cramped together

kpsherva avatar Nov 02 '23 14:11 kpsherva

small suggestion: could you increase a distance between + and New ? it seems a little bit too cramped together

I am not sure if what I did is correct in terms of good practices (let me know if it isn't): I added an ID to the label and added a margin-left.

Screenshot at Nov 06 09-41-55

alejandromumo avatar Nov 06 '23 08:11 alejandromumo

I am sure you checked, but just to be sure, does the link correctly redirect to login when anonymous?

ntarocco avatar Nov 06 '23 10:11 ntarocco

small suggestion: could you increase a distance between + and New ? it seems a little bit too cramped together

I am not sure if what I did is correct in terms of good practices (let me know if it isn't): I added an ID to the label and added a margin-left.

Screenshot at Nov 06 09-41-55

it seems to me like now there is a huge space on the left...

jbenito3 avatar Nov 06 '23 11:11 jbenito3

after some discussions, we decide it to postpone it until optimal solution is found

kpsherva avatar Nov 07 '23 16:11 kpsherva

This PR was automatically marked as stale.

github-actions[bot] avatar Jan 07 '24 06:01 github-actions[bot]