idutils icon indicating copy to clipboard operation
idutils copied to clipboard
verified publisher icon inveniosoftware

isbn: fix cases where masking fails

Open slint opened this issue 3 years ago • 4 comments

  • Fallbacks to a canonical ISBN value in case the hyphenation/masking fails.

slint avatar Oct 05 '22 08:10 slint

Coordination:

Placed in "Work in progress" because there is a rebase to be done and versioning to adjust. But it looks good to me! Once that's done, we can have another review or skip to merge as you wish @slint .

fenekku avatar Mar 14 '23 12:03 fenekku

Coordination: bumpety bump

fenekku avatar Mar 21 '23 11:03 fenekku

Coordination: @fenekku @slint shall we move this PR to To Review or ask @ntarocco for a second reviewer aprovement !

chokribr avatar Apr 24 '23 10:04 chokribr

I think here it's less a review than a conflict resolution rebase that is missing. Since that's usually better done by the original PR submitter, I would leave it as work in progress. If someone other than @slint has time and feels confident they can resolve the conflict that could be done too. Let's say we circle back around to this in 1 week?

fenekku avatar Apr 24 '23 17:04 fenekku