Intervals.jl icon indicating copy to clipboard operation
Intervals.jl copied to clipboard

Option to not do bounds checking?

Open rofinn opened this issue 7 years ago • 4 comments

It'd be nice if we could disable first and last order checking of arguments for performance reasons (maybe just don't have an inner constructor?).

rofinn avatar May 03 '18 22:05 rofinn

If you wrap bounds checking in @boundscheck, I believe the checks will be elided when called with @inbounds.

ararslan avatar May 15 '18 00:05 ararslan

I did some experimentation with @boundscheck and couldn't get it to work with this code. Additionally, I think using @inbounds here is misleading as what we really want to indicate is that the data in the constructor is ordered.

omus avatar May 31 '18 21:05 omus

I think not having an inner constructor would be the least intrusive option.

rofinn avatar Jun 01 '18 00:06 rofinn

I believe that we need to enforce that the left precedes the right. To remove that enforcement we would need to review the entire package to ensure there are no side effects.

omus avatar Jun 01 '18 01:06 omus