simple_deploy icon indicating copy to clipboard operation
simple_deploy copied to clipboard

Published 20 hours ago • verified publisher icon intuit

Confirm Prod Deployments

Open ghost opened this issue 12 years ago • 7 comments

The LC team would like an extra check added when doing prod releases. They would like to see an 'Are you sure' prompt when deploying to prod stacks as they feel it easy to get confused when deploying to qa, e2e or prod as it all looks the same.

ghost avatar Dec 03 '12 18:12 ghost

me too me too, can this be generified?

C On Dec 3, 2012, at 10:37 AM, Rick Mendes [email protected] wrote:

The LC team would like an extra check added when doing prod releases. They would like to see an 'Are you sure' prompt when deploying to prod stacks as they feel it easy to get confused when deploying to qa, e2e or prod as it all looks the same.

— Reply to this email directly or view it on GitHub.

geekychris avatar Dec 03 '12 18:12 geekychris

Generified across commands? I think so. Or did you mean something else?

ghost avatar Dec 03 '12 19:12 ghost

I envision this being a flag we set on a per stack basis. Maybe confirm. If set to true, any command ran against that stack that is not read only, will force the engineer to confirm the change.

weavenet avatar Dec 03 '12 21:12 weavenet

flag sounds like a good thing.

C On Dec 3, 2012, at 1:11 PM, Brett Weaver [email protected] wrote:

I envision this being a flag we set on a per stack basis. Maybe confirm. If set to true, any command ran against that stack that is not read only, will force the engineer to confirm the change.

— Reply to this email directly or view it on GitHub.

geekychris avatar Dec 03 '12 21:12 geekychris

It sounds like the issue is that it's not easy to tell what is prod or not. Given that the environment names are completely within the control of the user, I'm wondering if changing that would work.

Perhaps an example would help.

Instead of:

simple_deploy deploy -e prod_us_west_1 -n foo-bar

Perhaps this (or anything else that sticks out to the user):

simple_deploy deploy -e XXX_PROD_US_WEST_1_XXX -n foo-bar

Thoughts?

thbishop avatar Dec 04 '12 17:12 thbishop

That is what I do, no screw ups yet :)

weavenet avatar Dec 04 '12 19:12 weavenet

After a couple of conversations, there are two items at play here.

  1. It's hard to determine which environment they're deploying to.
  2. There's a possibility accidentally hitting the enter key which could have unintended consequences when not paying 100% attention to the details.

I think the existing ability to manipulate the env is sufficient for the first item and the proposed generic confirmation feature solves for the second.

thbishop avatar Dec 05 '12 21:12 thbishop