oauth-jsclient icon indicating copy to clipboard operation
oauth-jsclient copied to clipboard

[typescript][enhancement]: Update typescript sample with the latest typescript definitions

Open abisalehalliprasan opened this issue 5 years ago • 3 comments

Hacktoberfest is underway right now and we would love for you to contribute 🚀 . More information on #hacktoberfest is here

Develop-with-Intuit for Hacktoberfest

Problem

Update typescript sample with the latest typescript definitions index.d.ts file

Fix Needed

Update typescript sample with the latest typescript definitions and test the sample is working.

Instructions to use the sample app

In order to test the typings locally from the sample project, you'll need to link the intuit-oauth package with yarn or npm.

# Link local intuit-oauth branch with typings support to sample typescript project
yarn link
cd sample/typescript
yarn link intuit-oauth

PR Guidelines

Kindly follow the below instructions to submit your PR :

  • Fork and clone the repository (typescript branch).
  • Run npm install for dependencies.
  • Test all your changes.
  • Run npm test to execute all specs.

Once ready, please submit a PR to the typescript branch here.
Note : PR's will be merged to the master branch once all the testing is completed.

abisalehalliprasan avatar Oct 13 '20 23:10 abisalehalliprasan

Hey! I'd like to take a shot at this if it's fine.

100mik avatar Oct 18 '20 22:10 100mik

@100mik : Awesome. That would be great. However, this issue/fix would be dependent on #100 ( as the sample should refer to the latest typings ).

I suggest you can start on this story once we start getting more updates on the #100. Does that sound good to you?

abisalehalliprasan avatar Oct 19 '20 16:10 abisalehalliprasan

Yes that's perfectly fine. I don't mind helping out if needed once the current assignee has taken a shot at #100 Cheers!

100mik avatar Oct 19 '20 20:10 100mik