design-systems-cli icon indicating copy to clipboard operation
design-systems-cli copied to clipboard

Update playroom to latest version and apply type resolutions

Open kelyvin opened this issue 2 years ago • 0 comments

What Changed

Upgrade playroom to the latest 0.28.0, which brings in:

  • Dark Mode support
  • Support for ^4.3.2 TypeScript versions
  • Support for Webpack 5
  • Add .yarnrc to set the proper registry

Why

Libraries running on a newer version of TypeScript and wanted to run playroom required the latest version of Playroom. In addition, @type resolutions were required to resolve the latest playroom's type dependency chain. Otherwise, you would get issues like you see in the following CircleCI Build

Alternatively instead of resolutions, we can apply the skipLibCheck: true setting to our tsconfig's compilerOptions. However, that simply ignores the type checking rather than solving it.

📦 Published PR as canary version: 4.16.0--canary.698.19664.0

:sparkles: Test out this PR locally via:

npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
npm install @design-systems/[email protected]
# or 
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]
yarn add @design-systems/[email protected]

kelyvin avatar May 23 '22 18:05 kelyvin