auto icon indicating copy to clipboard operation
auto copied to clipboard

Fix: NPM GH release publishing should set latest

Open jackw opened this issue 1 year ago • 1 comments

What Changed

Updated the NPM plugin to set nextRelease flag when calling git.publish.

Why

It looks like GH releases in the NPM plugin aren't using the nextRelease flag that was introduced in #2391

fixes: #2422

Todo:

  • [ ] Add tests
  • [ ] Add docs

Change Type

Indicate the type of change your pull request is:

  • [ ] documentation
  • [x] patch
  • [ ] minor
  • [ ] major

jackw avatar Jan 22 '24 08:01 jackw

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7a6f0ae) 85.92% compared to head (fce0e96) 80.58%.

Files Patch % Lines
plugins/npm/src/index.ts 0.00% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2423      +/-   ##
==========================================
- Coverage   85.92%   80.58%   -5.34%     
==========================================
  Files          69       69              
  Lines        5675     5675              
  Branches     1332     1274      -58     
==========================================
- Hits         4876     4573     -303     
- Misses        718      719       +1     
- Partials       81      383     +302     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 24 '24 09:01 codecov[bot]

Seems like a duplicate of my fix https://github.com/intuit/auto/pull/2414

jazmon avatar Feb 21 '24 13:02 jazmon

@jackw or @jazmon I think the logic in your PRs should be combined

hipstersmoothie avatar Feb 21 '24 19:02 hipstersmoothie

@hipstersmoothie I combined the contents from this PR to my PR if you could have a look 🙏 https://github.com/intuit/auto/pull/2414

jazmon avatar Feb 22 '24 07:02 jazmon

Let's close this as @jazmon has gone to the trouble of bringing the two together. Awesome work everybody! 🚀

jackw avatar Feb 22 '24 10:02 jackw