auto icon indicating copy to clipboard operation
auto copied to clipboard

(docker plugin) fix git tagging command

Open ejhayes opened this issue 2 years ago • 1 comments

What Changed

Fixes bug introduced with #2232

Why

Previous fix creates git tags with git tag latest -mf "..." which results in an error like this:

Error: Running command 'git' with args [tag, latest, -mf, "Tag release alias: latest (vX.Y.Z)"] failed

This changes the command to use correct syntax for latest, canaries, and prereleases:

git tag -f latest -m "..."

Change Type

Indicate the type of change your pull request is:

  • [ ] documentation
  • [x] patch
  • [ ] minor
  • [ ] major

ejhayes avatar Sep 14 '22 18:09 ejhayes

This should be working now @hipstersmoothie, not sure why the pr-check job is failing

ejhayes avatar Sep 15 '22 06:09 ejhayes

Try running the CI again? This issue is affecting me also. My issues is taht the string appears to be not quoted.

Error: Running command 'git' with args [tag, pr-5805, -mf, Tag pull request canary: pr-5805 (1.0.0--canary.5805.28750)] failed

/bin/sh: 1: Syntax error: "(" unexpected

    at ChildProcess.<anonymous> (/home/circleci/repo/node_modules/@auto-it/core/dist/utils/exec-promise.js:58:31)
    at ChildProcess.emit (node:events:513:28)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:291:12)Error
    at Object.execPromise (/home/circleci/repo/node_modules/@auto-it/core/dist/utils/exec-promise.js:15:22)
    at /home/circleci/repo/node_modules/@auto-it/docker/dist/index.js:165:30
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

Exited with code exit status 1

Thanks

MrHash avatar Dec 02 '22 19:12 MrHash

🆙🙂

laughedelic avatar Jan 17 '23 16:01 laughedelic

Would be great to get this merged in!

ejhayes avatar Jan 26 '23 02:01 ejhayes

:rocket: PR was released in v10.38.0 :rocket:

hipstersmoothie avatar Feb 04 '23 19:02 hipstersmoothie