auto icon indicating copy to clipboard operation
auto copied to clipboard

Create Protected branch plugin

Open jBouyoud opened this issue 2 years ago • 2 comments

What Changed

New plugin to handle protected branch that enforce administrator enforcements.

Why

Todo: N/A

  • [x] Add tests
  • [x] Add docs

Change Type

Indicate the type of change your pull request is:

  • [ ] documentation
  • [ ] patch
  • [x] minor
  • [ ] major

jBouyoud avatar Jun 03 '22 13:06 jBouyoud

Codecov Report

Merging #2210 (80b635e) into main (3e1cd5c) will increase coverage by 0.15%. The diff coverage is 93.84%.

@@            Coverage Diff             @@
##             main    #2210      +/-   ##
==========================================
+ Coverage   80.44%   80.60%   +0.15%     
==========================================
  Files          67       69       +2     
  Lines        5519     5584      +65     
  Branches     1292     1300       +8     
==========================================
+ Hits         4440     4501      +61     
  Misses        711      711              
- Partials      368      372       +4     
Impacted Files Coverage Δ
plugins/protected-branch/src/index.ts 89.74% <89.74%> (ø)
plugins/protected-branch/src/GitOperator.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 91e0be2...80b635e. Read the comment docs.

codecov[bot] avatar Jun 03 '22 13:06 codecov[bot]

@hipstersmoothie anything that I can do to help merge this PR ?

jBouyoud avatar Aug 11 '22 07:08 jBouyoud

Hello 👋 Any update on this PR? I've tried it on my project and it works perfectly 👌

Sy1v4in avatar Jan 13 '23 07:01 Sy1v4in

@jBouyoud Could you update the lock file?

hipstersmoothie avatar Feb 03 '23 23:02 hipstersmoothie

:rocket: PR was released in v10.38.0 :rocket:

hipstersmoothie avatar Feb 04 '23 19:02 hipstersmoothie

🎉 Thanks

jBouyoud avatar Feb 06 '23 12:02 jBouyoud

@hipstersmoothie I just realize that I've an improvement on my side that I not push here (do not rely on gh CLI and use auti Git class instead in order to remove a dependency and handle rate limits). I'll try to open a new PR for that.

I see that you have implemented a cleanup (to delete the branch) ; You also have to think that the branch could not exists anymore for people using Github built-in branch deletion after merge.

jBouyoud avatar Feb 06 '23 13:02 jBouyoud

Pr?

hipstersmoothie avatar Feb 06 '23 15:02 hipstersmoothie

Please find the mentioned PR here

jBouyoud avatar Feb 08 '23 11:02 jBouyoud