QuickBooks-V3-PHP-SDK icon indicating copy to clipboard operation
QuickBooks-V3-PHP-SDK copied to clipboard

"com\intuit\..." prefixes on class types

Open themightychris opened this issue 4 years ago • 3 comments

What's with all the properties being declared with types like com\intuit\schema\finance\v3\IPPReferenceType:

https://github.com/intuit/QuickBooks-V3-PHP-SDK/blob/master/src/Data/IPPSalesTransaction.php#L71

When the namespace for IPPReferenceType is QuickBooksOnline\API\Data:

https://github.com/intuit/QuickBooks-V3-PHP-SDK/blob/master/src/Data/IPPReferenceType.php

This makes it impossible for a project setting these properties to pass static analysis without tons of exceptions

themightychris avatar Oct 23 '21 18:10 themightychris

This is incredibly annoying, please merge the PR I provided.

kkmuffme avatar Mar 05 '22 15:03 kkmuffme