QuickBooks-V3-PHP-SDK icon indicating copy to clipboard operation
QuickBooks-V3-PHP-SDK copied to clipboard

Published 20 hours ago • verified publisher icon intuit

Typo in CoreConstants.php

Open gmariani opened this issue 3 years ago • 8 comments 

    /**
     * Current QuickBooks Namespace for PHP SDK
     * @var int Deflate
     */
    const NAMEPSACE_DATA_PREFIX = 'QuickBooksOnline\\API\\Data\\';

NAMEPSACE_DATA_PREFIX should be NAMESPACE_DATA_PREFIX

gmariani avatar Jul 04 '21 16:07 gmariani

Hey, I would like to work on this issue please assign this to me.

yashasvimisra2798 avatar Jul 12 '21 17:07 yashasvimisra2798

@gmariani I have raised a PR fixing this issue, please check. Thank you!

yashasvimisra2798 avatar Jul 16 '21 05:07 yashasvimisra2798

Looks like this constant is also used in: src/XSD2PHP/src/com/mikebevz/xsd2php/Bind.php src/Core/Http/Serialization/XmlObjectSerializer.php src/Utility/MetadataExtractor.php src/Facades/FacadeHelper.php

Just changing src/Core/CoreConstants.php will cause the rest of the files/classes to break.

gmariani avatar Jul 16 '21 06:07 gmariani

Shall I make changes to these files as well?

yashasvimisra2798 avatar Jul 16 '21 06:07 yashasvimisra2798

Only if you don't want to break the SDK. lol

gmariani avatar Jul 16 '21 13:07 gmariani

Hey @gmariani I have raised a PR with the said changes, please guide me if anything else needs to be done

yashasvimisra2798 avatar Jul 19 '21 06:07 yashasvimisra2798

Are there any more changes to be done in the PR #411?

yashasvimisra2798 avatar Aug 06 '21 12:08 yashasvimisra2798

Not that i know of, i have not tested this. I was just reporting the issue.

gmariani avatar Aug 06 '21 13:08 gmariani