Typo in CoreConstants.php

[gmariani]

    /**
     * Current QuickBooks Namespace for PHP SDK
     * @var int Deflate
     */
    const NAMEPSACE_DATA_PREFIX = 'QuickBooksOnline\\API\\Data\\';

NAMEPSACE_DATA_PREFIX should be NAMESPACE_DATA_PREFIX

[yashasvimisra2798]

Hey, I would like to work on this issue please assign this to me.

[yashasvimisra2798]

@gmariani I have raised a PR fixing this issue, please check. Thank you!

[gmariani]

Looks like this constant is also used in: src/XSD2PHP/src/com/mikebevz/xsd2php/Bind.php src/Core/Http/Serialization/XmlObjectSerializer.php src/Utility/MetadataExtractor.php src/Facades/FacadeHelper.php

Just changing src/Core/CoreConstants.php will cause the rest of the files/classes to break.

[yashasvimisra2798]

Shall I make changes to these files as well?

[gmariani]

Only if you don't want to break the SDK. lol

[yashasvimisra2798]

Hey @gmariani I have raised a PR with the said changes, please guide me if anything else needs to be done

[yashasvimisra2798]

Are there any more changes to be done in the PR #411?

[gmariani]

Not that i know of, i have not tested this. I was just reporting the issue.