QuickBooks-V3-PHP-SDK
QuickBooks-V3-PHP-SDK copied to clipboard
Update Returns
I've also ran into an issue with pageNumber
not acting as an actual page number in the FindAll
method in DataService
. Instead of multiplying the pageNumber
with the pageSize
to get the startPosition
, pageNumber
was being used directly in the query, effectively making it a startOffset
and not a pageNumber
.
Since that's the case, I've renamed the variable to startOffset
to make its intent more clear. We could always rename it back and multiply properly if the original intent was to actually iterate by the pageSize
OMG GameCharmer - I just spent about 2 hours banging my head on the desk trying to figure out why the pageNumber was failing every time! It IS an offset. Shame on whoever wrote the code that way as it is clearly labeled and documented to be a page number.
@1127 If only they would accept pull requests :P