QuickBooks-V3-PHP-SDK icon indicating copy to clipboard operation
QuickBooks-V3-PHP-SDK copied to clipboard

setAccountingMethod expecting null instead of string

Open SynapticSoftware opened this issue 4 years ago • 3 comments

ReportService.php Line 279 should be:

 * @param **string** $accounting_method

SynapticSoftware avatar Oct 25 '19 03:10 SynapticSoftware

A PR with the change is welcome!

bsivalingam avatar Mar 06 '20 09:03 bsivalingam

Opening up our SDK for hacktoberfest contributions.

abisalehalliprasan avatar Sep 22 '20 00:09 abisalehalliprasan

HI I have just submitted a PR making the change. However, I see that there are many methods with params that need changing. Should they be changed as part of this PR too?