Ignite icon indicating copy to clipboard operation
Ignite copied to clipboard

switch to uglifyjs alternative

Open hipstersmoothie opened this issue 5 years ago • 10 comments

hipstersmoothie avatar Dec 14 '18 01:12 hipstersmoothie

Which alternative? What is the driving force behind wanting to switch?

bowbahdoe avatar Dec 15 '18 00:12 bowbahdoe

Terser. Reason for switching? I was using ignite and uglify was breaking my prod build On Fri, Dec 14, 2018 at 4:13 PM Ethan McCue [email protected] wrote:

Which alternative? What is the driving force behind wanting to switch?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/intuit/Ignite/issues/82#issuecomment-447516098, or mute the thread https://github.com/notifications/unsubscribe-auth/ABIyBJ2X7dobZme41YtPiGJy0Jl17nkbks5u5D69gaJpZM4ZSv5R .

hipstersmoothie avatar Dec 15 '18 00:12 hipstersmoothie

Off the top of my head the only other source aware minifier I can think of is the Google Closure Compiler. That would definitely break more than uglify, so it isn't a good option. Maybe switching to just whitespace only optimizations would do the trick?

bowbahdoe avatar Dec 15 '18 00:12 bowbahdoe

The mangle: false option in uglify might also resolve the issue

bowbahdoe avatar Dec 15 '18 00:12 bowbahdoe

webpack is switching to terser so that why it was my go to https://github.com/webpack/webpack/issues/7923

hipstersmoothie avatar Dec 15 '18 02:12 hipstersmoothie

seems its been merged https://github.com/webpack/webpack/pull/8392

hipstersmoothie avatar Dec 15 '18 02:12 hipstersmoothie

Oh I thought you said Terser as in you were going to say the next sentence in a Terser way. I did not know that was a thing.

bowbahdoe avatar Dec 15 '18 03:12 bowbahdoe

As in "Reason for switching?" is a terser way of saying "What is the driving force behind wanting to switch?"

bowbahdoe avatar Dec 15 '18 03:12 bowbahdoe

Hi, I'd like to pick up this issue! Lmk if there are any specific guidelines to be aware of for contributions :D

alinewm avatar Sep 27 '19 20:09 alinewm

No specific guidelines! go for it

hipstersmoothie avatar Sep 27 '19 20:09 hipstersmoothie