CloudRaider icon indicating copy to clipboard operation
CloudRaider copied to clipboard

Fixed test coverage report issues

Open vaisrinivasan opened this issue 2 years ago • 5 comments

What Changed

Bug fixes / additions done as part of this PR:

  1. Compilation error due to annotation dependency
  2. Jacoco instrumentation error
  3. Jacoco code coverage is all zero percent
  4. Link to code coverage report in README (For this, a coverage-reports folder has been added to cloudraider-core. If only the index.html is added, then the drilldown of the classes in jacoco will not work. Hence the entire jacoco report structure is added)

Why

Todo:

  • [ ] Add tests
  • [ ] Add docs
  • [ ] Add yourself to contributors (run yarn contributors:add)

vaisrinivasan avatar Oct 20 '22 18:10 vaisrinivasan

  1. Compilation error due to annotation dependency (mvn clean install) Before: image After: image
  2. Jacoco instrumentation error Before: image After: image
  3. Jacoco code coverage is all zero percent Before: image After: image

vaisrinivasan avatar Oct 20 '22 18:10 vaisrinivasan

This PR addresses https://github.com/intuit/CloudRaider/issues/38

vaisrinivasan avatar Oct 20 '22 18:10 vaisrinivasan

@vaisrinivasan Please check this: https://github.com/intuit/CloudRaider/issues/38#issuecomment-1289493223

rattandeep1998 avatar Oct 24 '22 19:10 rattandeep1998

@vaisrinivasan Please check this: #38 (comment)

Have addressed the comment. https://github.com/intuit/CloudRaider/issues/38#issuecomment-1291530358

vaisrinivasan avatar Oct 28 '22 13:10 vaisrinivasan

@rattandeep1998 : Just following up to check if this PR is good to be merged :)

vaisrinivasan avatar Nov 07 '22 08:11 vaisrinivasan