CardParts icon indicating copy to clipboard operation
CardParts copied to clipboard

Published 20 hours ago • verified publisher icon intuit

Darkmode

Open croossin opened this issue 5 years ago • 10 comments

Before you make a Pull Request, read the important guidelines:

Issue Link :link: #184

  • Is this a bug fix or a feature?
    • Feature
  • Does it break any existing functionality?
    • I think because we introduce some new properties to the theme protocol, it might cause some erroes

Goals of this PR :tada:

  • Why is the change important?
    • Its dark mode 😂
  • What does this fix?
  • How far has it been tested?

How Has This Been Tested :mag:

Please let us know if you have tested your PR and if we need to reproduce the issues. Also, please let us know if we need any relevant information for running the tests.

  • User Interface Testing
  • Application Testing

Test Configuration :space_invader:

  • Xcode version: 11.1 (11A1027)
  • Device/Simulator: Simulator
  • iOS version: iOS 13.1

Things to check on :dart:

  • [ ] My Pull Request code follows the coding standards and styles of the project
  • [ ] I have worked on unit tests and reviewed my code to the best of my ability
  • [ ] I have used comments to make other coders understand my code better
  • [ ] My changes are good to go without any warnings
  • [ ] I have added unit tests both for the happy and sad path
  • [ ] All of my unit tests pass successfully before pushing the PR
  • [ ] I have made sure all dependent downstream changes impacted by my PR are working

croossin avatar Jan 07 '20 18:01 croossin

Yes!! :)

lwdupont avatar Jan 07 '20 18:01 lwdupont

Is there anything holding this back from being merged? 😯

tys-adventure avatar Jan 21 '20 14:01 tys-adventure

@TyJPhillips Just fixing up some last second stuff

croossin avatar Jan 21 '20 14:01 croossin

Just trying to get CardPartAttributedTextView working nicely with dark mode Simulator Screen Shot - iPhone 11 Pro Max - 2020-01-21 at 07 00 30

croossin avatar Jan 21 '20 15:01 croossin

Just trying to get CardPartAttributedTextView working nicely with dark mode Simulator Screen Shot - iPhone 11 Pro Max - 2020-01-21 at 07 00 30

Looking good thus far sir! Looking forward to the merge, and keep up the good work!

tys-adventure avatar Jan 21 '20 15:01 tys-adventure

I believe we are good to go now!! @badrinathvm Feel free to take another look 👍

croossin avatar Jan 22 '20 18:01 croossin

And a huge shoutout to @lkeude96 for all of his contributions !!!!!

croossin avatar Jan 22 '20 18:01 croossin

@croossin Looks Good to me.

badrinathvm avatar Jan 22 '20 23:01 badrinathvm

Any plans to merge this?

ghost avatar Feb 21 '20 12:02 ghost

Any plans to merge this?

bevbomb avatar Jul 03 '20 05:07 bevbomb