rtabmap icon indicating copy to clipboard operation
rtabmap copied to clipboard

support gtsam 4.3 header migration

Open v4hn opened this issue 3 weeks ago • 2 comments

They recently split this class out in another header in their 4.3 development branch.

v4hn avatar Dec 06 '25 00:12 v4hn

LGTM! thank you

matlabbe avatar Dec 07 '25 19:12 matlabbe

Looks like kilted and rolling are using a 4.3 version older than this change added 2 weeks ago: https://github.com/borglab/gtsam/commits/develop/gtsam/nonlinear/NoiseModelFactorN.h

They just released 3 weeks ago a new version for ros2: https://github.com/borglab/gtsam/issues/2278

matlabbe avatar Dec 07 '25 21:12 matlabbe

Wonderful. I guess no choice but to wait for ros2 to pull in new versions once things settled down there, because the different development states share the version number. I packaged it for ROS-O in one of the builders last week and found this breaking change. I guess there is no harm in having it lie around depending on your preferences for the master branch.

v4hn avatar Dec 13 '25 00:12 v4hn