antd-scss-theme-plugin icon indicating copy to clipboard operation
antd-scss-theme-plugin copied to clipboard

Maintenance?

Open refucktor opened this issue 6 years ago • 6 comments

Hi guys, thanks for your work!!!

Seems like the project is kind of abandoned or maybe you don't have enough time to take care of the issues.

  • Are you accepting PR?
  • Would you recommend to contribute or rather fork the project and provide the necessary changes?

refucktor avatar Jan 14 '20 00:01 refucktor

We do accept pull requests, but I'm not actively using the project myself right now so this is a relatively low priority for me and it's hard to find time. I've had conversations with a few people about coming on as a maintainer, but they've fallen through. Would you have any interest in being a maintainer?

sangaline avatar Jan 14 '20 01:01 sangaline

Sorry for my late answer... and thanks for your reply

Unfortunately, I'm kind of running out of time, that's why I have to fork the project and incorporate some adjustments. Our previous setup was using less with antd and at some point, the development process was impossible, from out of memory while recompiling the change to wait minutes until the styles are compiled and the changes refreshed. I had three main issues with your package:

  1. Packages versions a bit old
  2. Latest sass-loader version compatibility
  3. Webpack resolve.alias compatibility WIthout the last one, I have to import the theme with relative path every time and with my proposal, I can use the alias from webpack to resolve the path and inject the style variables.

I would prefer to contribute to your project, cause I see much more value than creating a fork, just at the moment I'm running out of time and the team needs to prepare a big release.

refucktor avatar Jan 14 '20 03:01 refucktor

@refucktor would you be open to sharing your fork? We're in a similar boat.

bmgdev avatar Apr 02 '20 18:04 bmgdev

@bmgdev sure, here is the fork published as npm package @inventium/antd-scss-theme-plugin.

We came out with some pretty stable configuration, let me know if you need any help.

refucktor avatar Apr 03 '20 14:04 refucktor

@refucktor really appreciate that, thank you!

bmgdev avatar Apr 03 '20 22:04 bmgdev

Is anyone maintaining this project?

@refucktor might have to also use your fork as well 👀 the package warnings keeps coming up

MildTomato avatar May 20 '20 11:05 MildTomato