Marti Raudsepp

Results 331 comments of Marti Raudsepp

> Technically you can return other data types from get_queryset, see https://github.com/django/django/blob/main/django/forms/models.py That's surprising. What exactly is this link pointing to? I just found one `get_queryset` method there which _does_...

Yes, I think `QuerySet[_M]` is more appropriate here.

> However, I think it's good to actually enforce views to take a single request argument. What do you think? I believe it would break the hack that our FAQ...

@jorenham This is caused by #2000, any thoughts? I think we should do something here. I don't understand why for example `AbstractUser.Meta` is accessible, but `Permission.Meta` is not. ```python >>>...

Anyway, let's just see which classes have `.Meta` available and which don't. And then just add to stub classes according to that. Don't have time right now to open a...

> in VSCode the default bundled Django stubs (derived from [djagno-types](https://github.com/sbdchd/django-types)) are prioritized). [According to PEP 561](https://peps.python.org/pep-0561/#stub-only-packages), stubs-only packages don't need to include `py.typed`. > Note that for stub-only packages...

OK, per issue linked by Viicos, this has been reported upstream and there hasn't been any progress for months. But did you test that this solves the issue with django-stubs?...

I can't reprodce this. How are you running mypy? Are you sure that `django-stubs` is installed in that environment?

In your original report you mentioned `pre-commit`. I believe you need to explicitly configure additional packages to be installed into pre-commit's environment.

Assigned to @sobolevn. If you don't want to lead the review here, feel free to unassign yourself.