Marti Raudsepp
Marti Raudsepp
Original comment by @flaeppe https://github.com/typeddjango/django-stubs/issues/1337#issuecomment-1449863734 > I've touched the plugin code a bit and I'd would like to agree with both of your opinions regarding the hygienic plugin redesign. I've...
> I think it is a really bad idea. When we were originally designing the current state of the plugin, we already had static-analysis-only previous version of the plugin. It...
> if we want it to be performant it has to be cached, which means dealing with cache invalidation. I suspect the effort required to get a good caching strategy...
One of the motivations for me is that maintaining the list of ignores for our `typecheck_tests.py` (https://github.com/typeddjango/django-stubs/blob/master/scripts/enabled_test_modules.py#L60) by hand is quite a chore (there are over 450 lines of ignores!)....
In case someone wants more background on `typecheck_tests.py`, here's an explanation I wrote for djangorestframework-stubs: https://github.com/typeddjango/djangorestframework-stubs/pull/345#issuecomment-1421284085
Cross-posting some relevant discussion from a PR. Comment by @sobolevn https://github.com/typeddjango/django-stubs/pull/1552#pullrequestreview-1486393689 > A good question is: do we still need this typecheck test? > Maybe we can drop it and...
For context: `typecheck_tests` has been gone for ages now (#1556) and life has been much easier. Collapsing some outdated comments about that.
This seems like significant complexity to dynamically update the signature of just one function. There are lots more places in Django that depend on `AUTH_USER_MODEL`. Are you planning to extend...
> Yes `Any` is the right type for a general value in expressions, which are passed to `BaseExpression._parse_expressions` Hrm? I haven't looked into this in detail and I don't know...
Sorry for for not responding for so long. > No, because database drivers support registering extra types at runtime. This is not that uncommon, in a couple of past projects...