drive-server icon indicating copy to clipboard operation
drive-server copied to clipboard

Published 20 hours ago • verified publisher icon internxt

[PB-557] bug: file size from the drive-server comes as string

Open edisonjpadilla opened this issue 1 year ago • 9 comments

Added the virtual field numericSize in order to return the file size as a number instead of string. Whichever client needs the size as a number could simply use this property.

edisonjpadilla avatar Sep 21 '23 01:09 edisonjpadilla

@JoanVicens I thought the size was measured in MB, I'll make the change.

edisonjpadilla avatar Sep 21 '23 12:09 edisonjpadilla

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Sep 21 '23 12:09 sonarqubecloud[bot]

@PixoDev Can this break anything on mac?

JoanVicens avatar Sep 21 '23 13:09 JoanVicens

This will break a lot of API responses in the MacOS app because we are expecting an string there @JoanVicens @edisonjpadilla.

Let me think a solution for this so we don't break production already please, don't merge this yet. Will this apply to all the responses that includes the size field?

PixoDev avatar Sep 21 '23 13:09 PixoDev

We could add a new field so the clients can migrate to it and once every client no longer uses it change the size to number (and migrate again?) @sg-gs

JoanVicens avatar Sep 21 '23 14:09 JoanVicens