openlibrary icon indicating copy to clipboard operation
openlibrary copied to clipboard

Broken cover image

Open zorae opened this issue 1 year ago • 7 comments

Problem

Some editions have a cover image that cannot be loaded/rendered.

IMG_3674

Reproducing the bug

Navigate to the following edition: OL13502500M

  • Expected behavior: Either there is no cover image, or there is a visible cover image
  • Actual behavior: The browser displays a broken image placeholder

Context

  • Browser: Safari
  • OS: iPadOS 18
  • Logged in: Y
  • Environment (prod, dev, local): prod

Breakdown

Requirements Checklist

  • [ ]

Related files

Stakeholders


Instructions for Contributors

  • Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.

zorae avatar Oct 01 '24 18:10 zorae

@zorae, I currently see a cover for this specific edition. I am curious if you continue to not see one. image

scottbarnes avatar Oct 02 '24 02:10 scottbarnes

In Safari on both iPhone and iPad, the image is still broken for me. Maybe you’re serving an unusual image format?

zorae avatar Oct 02 '24 06:10 zorae

@scottbarnes The -M version of the image seems to work correctly. But when navigating to the -L image URL, I get the following error message:

cmd: LANG=en_US.UTF-8 timeout 180 unzip -p '/16/items/olcovers674/olcovers674-L.zip' '6747253-L.jpg' 2>/dev/null
failed with exit status: 11

zorae avatar Oct 02 '24 07:10 zorae

Hii!! Can i work on it?

Bishal-35 avatar Oct 11 '24 15:10 Bishal-35

@Bishal-35, thanks for your interest in this. I would say hold that thought until after this issue is triaged on Monday, unless you have a really clear vision for how to fix it, as I think this may require additional privileges / staff.

For my part, I'm curious to know what the output is when STDERR isn't discarded, and I think that will may depend on what's inside /16/items/olcovers674/olcovers674-L.zip, and whether that file exists at all.

scottbarnes avatar Oct 11 '24 17:10 scottbarnes

Okay. I will for it

Bishal-35 avatar Oct 11 '24 17:10 Bishal-35

Labeled as https://github.com/internetarchive/openlibrary/labels/State%3A%20Blocked until archive.org is back up.

jimchamp avatar Oct 14 '24 19:10 jimchamp