openlibrary icon indicating copy to clipboard operation
openlibrary copied to clipboard

Verify BWBCoverBot imported all covers correctly

Open scottbarnes opened this issue 1 year ago • 1 comments

Problem

This issue can only be completed by staff.

BWBCoverBot recently finished importing covers from the BWB covers zips.

We need to look at the August 31 dump and ensure that all covers from the zips are present in the dump. The zips to compare with are found in the "done" directory on ol-home0.

Reproducing the bug

No response

Context

No response

Breakdown

Requirements Checklist

  • [ ] ensure that for every cover ISBN in the BWB cover zips in the "done" directory on ol-home0, the associated edition with that ISBN in the editions dump has at least one cover. Ensure duplicate editions (where the same ISBN is associated with multiple editions) is accounted for.
  • [ ] Track how often edition/ISBN dupes exist and how many times only one edition has a cover associated with it. For this, check what type of query BWBCoverBot uses and perhaps use something like https://openlibrary.org/query.json?type=/type/edition&isbn_10=1111111111&sort=created if BWBCoverBot is using /isbn (and therefore only accessing index 0 from the list of matches).

Related files

Stakeholders


Instructions for Contributors

  • Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.

scottbarnes avatar Aug 27 '24 16:08 scottbarnes

An update on this: the process, BWBCoverBot, etc., appear to be working as expected. The issue is that thousands of ISBNs associated with covers in the zips simply are not in Open Library.

I've updated the issue, though perhaps a new issue is needed? Not sure.

scottbarnes avatar Sep 15 '24 01:09 scottbarnes

Having determined that BWBCoverBot is working as expected, and that the 'problem' here was that covers were not imported simply because the ISBNs are not in Open Library, this issue is being closed.

Next steps can be found in #9925.

scottbarnes avatar Oct 02 '24 02:10 scottbarnes