openlibrary icon indicating copy to clipboard operation
openlibrary copied to clipboard

Fix compact title scrolling issue

Open schu96 opened this issue 1 year ago • 4 comments

Closes #9584

Fix

Technical

Removes isTitleVisible boolean in favor of directly checking if the compact element does not contain the .hidden class for more reliable behavior.

Testing

Manually replicated erratic scrolling behavior as seen in #9584

Stakeholders

@RayBB

schu96 avatar Aug 27 '24 00:08 schu96

@schu96 please provide a video demonstrating the fix. You can upload it directly to github. If your file is too big you can compress it easily via https://tools.rotato.app/compress

RayBB avatar Aug 27 '24 01:08 RayBB

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 16.46%. Comparing base (ce16a79) to head (c72ca5e). Report is 287 commits behind head on master.

Files Patch % Lines
...rary/plugins/openlibrary/js/compact-title/index.js 0.00% 0 Missing and 2 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9810      +/-   ##
==========================================
+ Coverage   16.06%   16.46%   +0.40%     
==========================================
  Files          90       91       +1     
  Lines        4769     4894     +125     
  Branches      832      853      +21     
==========================================
+ Hits          766      806      +40     
- Misses       3480     3554      +74     
- Partials      523      534      +11     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Aug 27 '24 01:08 codecov-commenter

https://github.com/user-attachments/assets/9c49e6c7-89c5-4dba-8470-e97870332460

schu96 avatar Aug 27 '24 21:08 schu96

@jimchamp could you take a look at this one? I believe you know this code best!

cdrini avatar Aug 28 '24 15:08 cdrini