openlibrary icon indicating copy to clipboard operation
openlibrary copied to clipboard

Utilize cover height and width to prevent page layout shifting

Open RayBB opened this issue 1 year ago • 0 comments

Problem

Followup now that https://github.com/internetarchive/openlibrary/issues/9156 is done

A clear and concise description of what you want to happen

We should start setting the height and width on covers across the website to stop layout shifting.

Additional Context

https://covers.openlibrary.org/b/id/12547191.json

Proposal & Constraints

What is the proposed solution / implementation?

Is there a precedent of this approach succeeding elsewhere?

Which suggestions or requirements should be considered for how feature needs to appear or be implemented?

List of places it probably should be set:

  • Carousels
  • Author pages (for works and author image)
  • Search results
  • Lists pages
  • Probably more

Leads

Related files

Stakeholders

@cdrini can update the ticket with additional info.


Instructions for Contributors

  • Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.

RayBB avatar Aug 13 '24 14:08 RayBB